Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove strong reference retain cycle from camera preview view model #135

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

phantumcode
Copy link
Member

Issue #, if available:
#129

Description of changes:

  • Refactor and remove strong reference retain cycle between CameraPreviewViewModel and LivenessCaptureSession
  • Tested and verified that strong reference doesn't exists when viewed in Xcode's memory graph

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested review from a team as code owners April 25, 2024 15:23
@phantumcode phantumcode merged commit 930462b into main Apr 25, 2024
6 checks passed
@phantumcode phantumcode deleted the fix/strong_retain_cycle branch April 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants