Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add attempt count changes #137

Merged
merged 5 commits into from
May 6, 2024
Merged

chore: Add attempt count changes #137

merged 5 commits into from
May 6, 2024

Conversation

thisisabhash
Copy link
Member

Issue #, if available:

Description of changes:
Add attempt count changes and update UI for result view in HostApp

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash marked this pull request as ready for review May 6, 2024 05:21
@thisisabhash thisisabhash requested review from a team as code owners May 6, 2024 05:21
phantumcode
phantumcode reviewed May 6, 2024
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
@thisisabhash thisisabhash merged commit 3073bf1 into feat/no-light-support May 6, 2024
4 checks passed
@thisisabhash thisisabhash deleted the chore/attempt-count-changes branch May 6, 2024 17:14
thisisabhash added a commit that referenced this pull request Jul 1, 2024
@thisisabhash
chore: Add attempt count changes (#137)
e8643b7 
* chore: Add attempt count changes

* Fix unit tests

* add unit tests

* Update region for example liveness view

* Update amplify-swift dependency
thisisabhash added a commit that referenced this pull request Aug 22, 2024
@thisisabhash
chore: Add attempt count changes (#137)
16a6d57 
* chore: Add attempt count changes

* Fix unit tests

* add unit tests

* Update region for example liveness view

* Update amplify-swift dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantumcode phantumcode phantumcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisabhash @phantumcode