Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor session fit timeout from backend service #46

Merged
merged 6 commits into from
Aug 25, 2023
Merged

chore: refactor session fit timeout from backend service #46

merged 6 commits into from
Aug 25, 2023

Conversation

phantumcode
Copy link
Member

Issue #, if available:

Description of changes:

  • update liveness fit timeout to be configurable from the backend service
  • update amplify swift version dependency
  • update library versioning

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode marked this pull request as ready for review August 25, 2023 14:25
@phantumcode phantumcode requested review from a team as code owners August 25, 2023 14:25
@phantumcode phantumcode changed the title refactor: get fit timeout from backend service chore: refactor session fit timeout from backend service Aug 25, 2023
@phantumcode phantumcode merged commit aab92ed into main Aug 25, 2023
1 check passed
@phantumcode phantumcode deleted the phantum/refactor_timeout branch August 25, 2023 18:43
phantumcode added a commit that referenced this pull request Aug 31, 2023
@phantumcode
Merge branch 'main' into release
f015e12 
* main:
  chore: update face fit instruction text and error message (#49)
  chore: refactor session fit timeout from backend service (#46)
  chore: provide more fine-grained websocket close code on errors (#44)
devedup pushed a commit to devedup/amplify-ui-swift-liveness that referenced this pull request Sep 12, 2023
@phantumcode @devedup
chore: refactor session fit timeout from backend service (aws-amplify#46
c845d22 
)

* refactor: get fit timeout from backend service

* chore: update version

* chore: update amplify swift dependency

* chore: refactor timeout

* chore: update amplify version

* chore: code cleanup
phantumcode added a commit that referenced this pull request Sep 12, 2023
@phantumcode
Merge branch 'main' into phantum/automation
e6fc1e4 
* main:
  chore: update face fit instruction text and error message (#49)
  chore: refactor session fit timeout from backend service (#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atierian atierian atierian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phantumcode @atierian