Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update session timed out error to be non-blocking #65

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Oct 20, 2023

Issue #, if available:
#61
Description of changes:

  • Dispatch session time out error to be async to unblock component completion handler
    Check points: (check or cross out if not relevant)
  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested review from a team as code owners October 20, 2023 16:26
@phantumcode phantumcode temporarily deployed to Fortify October 20, 2023 16:28 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify October 20, 2023 19:55 — with GitHub Actions Inactive
@phantumcode phantumcode merged commit 37ab633 into main Oct 20, 2023
6 checks passed
@phantumcode phantumcode deleted the fix/session_timed_out branch October 20, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants