Skip to content

Commit

Permalink
Do not log in aws_credentials_provider
Browse files Browse the repository at this point in the history
Currently we log errors even if one of the credentials are
available, which is verbose and often confusing.

Given we already log or fail when no credentials are available,
let's remove the logging from individual providers.
  • Loading branch information
josevalim authored Nov 14, 2023
1 parent 57e4512 commit 6f5d031
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/aws_credentials_provider.erl
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ evaluate_providers([ Provider | Providers ], Options, Errors) ->
String = "Provider ~p reports ~p",
Args = [Provider, Error],
Metadata = #{domain => [aws_credentials]},
aws_credentials:log_error(String, Args, Metadata),
evaluate_providers(Providers, Options, [{String, Args, Metadata} | Errors]);
{ok, Credentials, Expiration} ->
{ok, Credentials, Expiration}
Expand Down

0 comments on commit 6f5d031

Please sign in to comment.