Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(idempotency): fix highlight and import path #4154

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Apr 18, 2024

Issue number: #4153

Summary

Changes

Please provide a summary of what's being changed

This PR fixes the import path problem and highlights in the "Manipulating idempotent response" section of the docs.

image

User experience

Please share what the user experience looks like before and after this change

This should help users of the new feature to have a better experience.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
@rubenfonseca rubenfonseca linked an issue Apr 18, 2024 that may be closed by this pull request
1 task
@rubenfonseca rubenfonseca marked this pull request as ready for review April 18, 2024 12:43
@rubenfonseca rubenfonseca requested a review from a team as a code owner April 18, 2024 12:43
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rubenfonseca rubenfonseca merged commit c30bbdd into develop Apr 18, 2024
4 checks passed
@rubenfonseca rubenfonseca deleted the rf/4153 branch April 18, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: import error and bad highlights on the Idempotency docs
2 participants