Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Ignore asset changes in snapshot tests #875

Conversation

konokenj
Copy link
Contributor

In this repository, Dependabot automatically updates dependent packages. However, when AWS SDK, X-Ray, and others are updated, asset hash of Lambda functions changes, making it impossible to merge automatically. To avoid this, using Jest's functionality to replace asset hash with a fixed string in snapshot tests.


By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).

Copy link
Contributor

@ohmurayu ohmurayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

mergify bot commented Sep 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8d1e1e0 into aws-samples:main Sep 25, 2024
7 checks passed
Copy link

mergify bot commented Sep 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants