feat(events-targets): prevent to create a log group resource policy - #38609
Open
Tietew wants to merge 4 commits into
Open
feat(events-targets): prevent to create a log group resource policy#38609Tietew wants to merge 4 commits into
Tietew wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31404.
Reason for this change
A CloudWatch LogGroup target creates a custom resource to create a LogGroup Resource Policy to permit EventBridge to put log events to the LogGroup. However, there is a strict quota of 10 Resource Policies per account per region. This therefore limits the amount of EventBridge rules targetting to CloudWatch Logs.
Description of changes
An optional prop
createLogGroupResourcePolicyhas been added to theLogGroupProps. When set tofalse, creation of LogGroup Resource Policy will be omitted. The default value istrueto keep current behavior.Setting
createLogGroupResoucePolicyto false needs user to create a LogGroup Resouce Policy separately. See README for details.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit tests:
createLogGroupResourcePolicyis false.Added a event rule with
createLogGroupResourcePolicyset to false to the existing integ test.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license