Speed up autocomplete index generation with a single SQLite transaction - #10596
Open
ashovlin wants to merge 1 commit into
Open
Speed up autocomplete index generation with a single SQLite transaction#10596ashovlin wants to merge 1 commit into
ashovlin wants to merge 1 commit into
Conversation
ashovlin
commented
Aug 23, 2026
| def generate_index(self, clidriver): | ||
| for indexer in self._indexers: | ||
| indexer.generate_index(clidriver) | ||
| for index_builder in self._indexers: |
Member
Author
There was a problem hiding this comment.
This was shadowing an import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #8889
Description of changes: Speeds up the autocomplete index generation by wrapping it in a single transaction.
I was looking at our CI timing, and this seems especially slow on Windows - spot-checking another PR,
install-dependenciesis 3-4 minutes on Linux/MacOS, but ~15 minutes on Windows. It should also benefit source installation users and package maintainers as suggested in the issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.