Skip to content

Commit

Permalink
Merge pull request #666 from aws/dev
Browse files Browse the repository at this point in the history
chore: release 1.0
  • Loading branch information
philasmar authored Jul 5, 2022
2 parents 463e09d + 655cb16 commit 48ef3bc
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 10 deletions.
4 changes: 3 additions & 1 deletion site/content/docs/commands/project.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@
Generates and saves the deployment CDK project in a user provided directory path without proceeding with a deployment. Allows user to customize the CDK project before deploying the application.

### Examples
TBD...
```
dotnet aws deployment-project generate --region us-west-2
```
7 changes: 4 additions & 3 deletions site/content/docs/commands/server-mode.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Description
Starts the tool in the server mode to provide integration with IDEs, for example Visual Studio. This tool is not intended for the end user usage unless you are writing a custom integration into an IDE.

### Options

TODO
### Examples
```
dotnet aws server-mode --port 1234 --parent-pid 12345
```
4 changes: 0 additions & 4 deletions site/content/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ AWS Deploy tool is available for download as a NuGet package. See [How to instal
### ... in AWS Toolkit for Visual Studio
The AWS Toolkit for Visual Studio exposes the same deployment functionality via **Publish to AWS** feature. For information about toolkit versions and using the feature, see [Publish to AWS](https://docs.aws.amazon.com/AWSToolkitVS/latest/UserGuide/publish-experience.html) in the [AWS Toolkit for Visual Studio User Guide](https://docs.aws.amazon.com/AWSToolkitVS/latest/UserGuide/).

## What's new?

TODO

## Additional Resources

* The [aws-dotnet-deploy](https://github.com/aws/aws-dotnet-deploy) GitHub repo.
Expand Down
2 changes: 1 addition & 1 deletion site/content/troubleshooting-guide/missing-dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This section of the troubleshooting guide explains how to determine, diagnose, a

**Why is this happening**: AWS.Deploy.Tools relies on [AWS Cloud Development Kit](https://aws.amazon.com/cdk/) (CDK) to provision resources for your cloud application. AWS CDK requires Node.js to be installed in your machine. See the [CDK's FAQs](https://aws.amazon.com/cdk/faqs/) for more information about how it uses Node.js.

*Minimum required Node.js version >= 10.13.0*
*Minimum required Node.js version >= 14.17.0*

**Resolution**: See [here](https://nodejs.org/en/download/) to install Node.js on your system.

Expand Down
1 change: 1 addition & 0 deletions src/AWS.Deploy.Common/Recipes/OptionSettingItem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ public partial class OptionSettingItem : IOptionSettingItem
/// <summary>
/// The validation state of the setting that contains the validation status and message.
/// </summary>
[JsonIgnore]
public OptionSettingValidation Validation { get; set; }

public OptionSettingItem(string id, string fullyQualifiedId, string name, string description)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,15 @@
"DefaultValue": "Sun:00:00",
"AdvancedSetting": true,
"Updatable": true,
"Validators": [
{
"ValidatorType": "Regex",
"Configuration": {
"Regex": "^(Mon|Tue|Wed|Thu|Fri|Sat|Sun):(0[0-9]|1\\d|2[0-3]):(0[0-9]|1\\d|2\\d|3\\d|4\\d|5\\d)$",
"ValidationFailedMessage": "Invalid Preferred Start Time. You need to specify a day and time in the 'day:hour:minute' format such as 'Sun:00:00'."
}
}
],
"DependsOn": [
{
"Id": "ElasticBeanstalkManagedPlatformUpdates.ManagedActionsEnabled",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,15 @@
"DefaultValue": "Sun:00:00",
"AdvancedSetting": true,
"Updatable": true,
"Validators": [
{
"ValidatorType": "Regex",
"Configuration": {
"Regex": "^(Mon|Tue|Wed|Thu|Fri|Sat|Sun):(0[0-9]|1\\d|2[0-3]):(0[0-9]|1\\d|2\\d|3\\d|4\\d|5\\d)$",
"ValidationFailedMessage": "Invalid Preferred Start Time. You need to specify a day and time in the 'day:hour:minute' format such as 'Sun:00:00'."
}
}
],
"DependsOn": [
{
"Id": "ElasticBeanstalkManagedPlatformUpdates.ManagedActionsEnabled",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,23 @@ public async Task ApplicationNameValidationTest(string value, bool isValid)
await Validate(optionSettingItem, value, isValid);
}

[Theory]
[InlineData("Sun:00:00", true)]
[InlineData("sun:00:00", false)]
[InlineData("Suns:00:00", false)]
[InlineData("Mon:23:59", true)]
[InlineData("Mon:24:00", false)]
[InlineData("Mon:00:60", false)]
[InlineData("", false)]
[InlineData("test", false)]
public async Task PreferredStartTimeValidationTest(string value, bool isValid)
{
var optionSettingItem = new OptionSettingItem("id", "fullyQualifiedId", "name", "description");
// valid examples are in the 'day:hour:minute' pattern such as 'Sun:00:00'
optionSettingItem.Validators.Add(GetRegexValidatorConfig("^(Mon|Tue|Wed|Thu|Fri|Sat|Sun):(0[0-9]|1\\d|2[0-3]):(0[0-9]|1\\d|2\\d|3\\d|4\\d|5\\d)$"));
await Validate(optionSettingItem, value, isValid);
}

[Theory]
[InlineData("abc-123", true)]
[InlineData("abc-ABC-123-xyz", true)]
Expand Down
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "0.50",
"version": "1.0",
"publicReleaseRefSpec": [
".*"
],
Expand Down

0 comments on commit 48ef3bc

Please sign in to comment.