Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRA] Update service clients to remove usage of fallback credentials factory #3546

Open
wants to merge 1 commit into
base: sra-identity-auth
Choose a base branch
from

Conversation

muhammad-othman
Copy link
Member

@muhammad-othman muhammad-othman commented Nov 6, 2024

Description

  • Remove the usage of FallbackCredentialFactory in service client constructors (limited to AutoScaling service for now to avoid huge merge conflicts later).
  • Rename AmazonServiceClient.Credentials to be DefaultAWSCredentials.
  • Added new IdentityResolverConfiguration property to the client config.
  • Marked the ClientConfig.AWSTokenProvider property as obsolete.

TODO: Remove the creation of the Signer property (will work on this part while updating the signer handler).

Motivation and Context

DOTNET-7538

@muhammad-othman muhammad-othman force-pushed the muhamoth/DOTNET-7538-sra-remove-fallbackcredentialsfactory-from-serviceclients branch from ac78a48 to a7af869 Compare November 6, 2024 18:56
Comment on lines +61 to +62
/// Gets the configuration for identity resolvers used by the service client, which manages
/// the resolvers used to obtain various types of identities.
Copy link
Contributor

@dscpinheiro dscpinheiro Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Gets the configuration for identity resolvers used by the service client, which manages
/// the resolvers used to obtain various types of identities.
/// Gets the configuration for the identity resolvers configured in the service client.

I think the documentation could be improved further, but I don't have a better suggestion at the moment (looks like Java ended up not using *Configuration at all: aws/aws-sdk-java-v2#4423).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see that and it took me a while to figure out that the IdentityResolvers is the IdentityResolverConfiguration mentioned in the SRA, so I would prefer to use the SRA names to make it easier to find what it means in the SRA unless we have a good reason not to do so.

Copy link
Contributor

@dscpinheiro dscpinheiro Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, for sure. I wasn't suggesting renaming the type, just mentioning we can improve the documentation for this property (since it's visible in the config and may not be clear to customers at first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants