Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nexus): coin type should be ICS20 if the coin is from external cosmos chain #2194

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

fish-sammy
Copy link
Contributor

@fish-sammy fish-sammy commented Oct 10, 2024

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner October 10, 2024 20:18
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.21%. Comparing base (57ecd83) to head (da162d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/nexus/keeper/lockable_asset.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2194   +/-   ##
=======================================
  Coverage   39.20%   39.21%           
=======================================
  Files         373      373           
  Lines       31726    31731    +5     
=======================================
+ Hits        12439    12444    +5     
- Misses      18346    18347    +1     
+ Partials      941      940    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

x/nexus/keeper/lockable_asset.go Outdated Show resolved Hide resolved
x/nexus/keeper/lockable_asset.go Show resolved Hide resolved
x/nexus/keeper/lockable_asset.go Outdated Show resolved Hide resolved
x/nexus/keeper/lockable_asset.go Show resolved Hide resolved
x/nexus/keeper/lockable_asset.go Show resolved Hide resolved
x/nexus/keeper/lockable_asset.go Show resolved Hide resolved
@fish-sammy fish-sammy merged commit 5d08029 into main Oct 14, 2024
8 of 9 checks passed
@fish-sammy fish-sammy deleted the fix/lockable-asset branch October 14, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants