Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/axelar query migration #416

Merged
merged 17 commits into from
Aug 19, 2024
Merged

Conversation

SGiaccobasso
Copy link
Collaborator

@SGiaccobasso SGiaccobasso commented Aug 7, 2024

Description

Migrated the getNativeGasBaseFee function from SDK to the API package.

⛑️ What was done:

Created the function, corrected typescript errors, created auxiliary files and added dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Ready to merge

🧪 How to test:

There's a test for this function in axelarjs/packages/api/src/axelar-query/client.spec.ts, you can run it from axelarjs/packages/api with the command pnpm run test.

🗒️ Notes:

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Santiago Giaccobasso and others added 2 commits August 6, 2024 16:59
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
axelar-maestro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 3:13pm
axelar-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 3:13pm
axelar-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 3:13pm

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 71956f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@axelarjs/api Patch
@axelarjs/deposit-address Patch
@axelarjs/maestro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@npty npty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there're lots of types migrated from the SDK v1. Can you add only functions that the function getNativeBaseFee relies on for now? However, I think we can keep the validateChain utils. We may use it to improve our validation logic. You may backup other types and functions in another branch for now.

packages/api/src/axelar-query/chains/index.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/services/RestService.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/isomorphic.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/isomorphic.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/isomorphic.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/isomorphic.ts Show resolved Hide resolved
packages/api/src/axelar-query/chains/index.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/chains/index.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/types.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/isomorphic.ts Outdated Show resolved Hide resolved
packages/api/package.json Outdated Show resolved Hide resolved
packages/api/src/axelar-query/isomorphic.ts Outdated Show resolved Hide resolved
packages/api/src/axelar-query/types.ts Outdated Show resolved Hide resolved
@SGiaccobasso SGiaccobasso merged commit d735846 into main Aug 19, 2024
5 checks passed
@SGiaccobasso SGiaccobasso deleted the feature/axelar-query-migration branch August 19, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants