-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/axelar query migration #416
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 71956f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there're lots of types migrated from the SDK v1. Can you add only functions that the function getNativeBaseFee
relies on for now? However, I think we can keep the validateChain
utils. We may use it to improve our validation logic. You may backup other types and functions in another branch for now.
…apt response object
Description
Migrated the
getNativeGasBaseFee
function from SDK to the API package.⛑️ What was done:
Created the function, corrected typescript errors, created auxiliary files and added dependencies.
Type of change
🧪 How to test:
There's a test for this function in
axelarjs/packages/api/src/axelar-query/client.spec.ts
, you can run it fromaxelarjs/packages/api
with the commandpnpm run test
.🗒️ Notes: