fix: search interchain tokens query searching only first chain #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 92c813a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
npty
previously approved these changes
Sep 20, 2024
apps/maestro/src/server/routers/interchainToken/searchInterchainToken.ts
Outdated
Show resolved
Hide resolved
npty
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎫 Issue:
⛑️ What was done:
Fixed an issue where searching a token without specifying chain id was failing.
The issue was that the query was returning
undefinedand notnullas expected by the code, returning only the result of the first chain searched.When the chain was specified, the query was looking for the specified chain first, that's what made it work.
Type of change
Please delete options that are not relevant.
🧪 How to test:
Run the app and go to
http://localhost:3000/api/interchain-token/search?tokenAddress=0x0c66d591d1ff5944A44aebB65c33f6B6e82a124FThe same query without the change should fail.
🗒️ Notes:
🎥 Recording:
fix.mov
Closes #453