feat: generic workspaces #1116
Merged
feat: generic workspaces #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
added a commit
that referenced
this pull request
Jun 11, 2024
this is half-implemented as the other half is in #1116
Gankra
force-pushed
the
gen-workspaces
branch
2 times, most recently
from
fbaf30d
to
ec36fb8
Compare
mistydemeo
approved these changes
Jun 13, 2024
| // `(target, pkg_idx)` uniquely identifies a build we need to do, | ||
| // so group all the binaries under those buckets and add a build for each one | ||
| // (targets is handled by the loop we're in) | ||
| let mut builds_by_pkg_idx = SortedMap::new(); |
There was a problem hiding this comment.
I wonder if we'd ever want a helper for this, if we end up finding ourselves wanting to do something similar in another place.
ashleygwilliams
pushed a commit
that referenced
this pull request
Jun 13, 2024
this is half-implemented as the other half is in #1116
mistydemeo
force-pushed
the
gen-workspaces
branch
from
17eaa91
to
7f3bd1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paired with axodotdev/axoproject#136