FilterX: fix invalid LogMessage variables access #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
7 times, most recently
from
e359d69
to
8bef0ba
Compare
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
2 times, most recently
from
635b6f6
to
3dd8481
Compare
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
This is to better indicate the intention of synchronizing FilterX -> LogMessage. Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
from
7dc6233
to
e67d698
Compare
…rection Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
This will be used in _update_repr as that method should update variables with new values regardless of their current value's validity. Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
This is required as _update_repr should update values regardless of their current validity. Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
These type of variables should only be returned if they are in sync with the scope (log_msg_has_changes flag is FALSE). Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
OverOrion
force-pushed
the
filterx-context-scope-fix-minimal
branch
from
e67d698
to
88b4238
Compare
OverOrion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes accessing
LogMessagetype FilterX variables in case there had been changes betweenfilterxblocks.