-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: factor out schema related functionality from bigquery to common #338
Open
alltilla
wants to merge
17
commits into
axoflow:main
Choose a base branch
from
alltilla:grpc-schema-common
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Out intention is to batch messages that correspond to the same label set. If between two messages the label set changes, but they arrive to the same worker, we should flush the previous batch. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Will be useful for templated headers as well. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
This will be needed for the dynamic headers. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
It must be enabled in the derived class, and prepare_context_dynamic() must be used if so. This is not part of this commit, enabling it will be done in subsequent commits. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
It will be needed there as well. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
We are planning to introduce an opt-in grpc_dest_schema_option nonterminal. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
This Pull Request introduces config grammar changesaxoflow/71be47e0d85d46e497584cf39d346164a7e0c89b -> alltilla/grpc-schema-common --- a/destination
+++ b/destination
axosyslog-otlp(
+ frac-digits(<nonnegative-integer>)
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
+ local-time-zone(<string>)
+ on-error(<string>)
+ send-time-zone(<string>)
+ template-escape(<yesno>)
+ time-zone(<string>)
+ ts-format(<string>)
)
bigquery(
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
)
loki(
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
)
opentelemetry(
+ frac-digits(<nonnegative-integer>)
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
+ local-time-zone(<string>)
+ on-error(<string>)
+ send-time-zone(<string>)
+ template-escape(<yesno>)
+ time-zone(<string>)
+ ts-format(<string>)
)
syslog-ng-otlp(
+ frac-digits(<nonnegative-integer>)
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
+ local-time-zone(<string>)
+ on-error(<string>)
+ send-time-zone(<string>)
+ template-escape(<yesno>)
+ time-zone(<string>)
+ ts-format(<string>)
)
|
alltilla
force-pushed
the
grpc-schema-common
branch
from
October 12, 2024 13:23
7072ae4
to
86b8aa2
Compare
In order to opt-in for schema support, a derived class must: * include grpc_dest_schema_option in the grammar * implement the string -> descriptor type mapping * store and init a Schema instance in the driver * implement the get_schema() method to return the stored Schema instance The derived class can interface with the Schema by these functions: * init() * empty() * format() * get_schema_descriptor() Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
grpc-schema-common
branch
from
October 12, 2024 15:45
86b8aa2
to
c421450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for other drivers that want to support setting the message schema from config.
Depends on #334