XIVY-13178 wip: map ivy.yaml to locally served schemas #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-rew
force-pushed
the
XIVY-13178-offline
branch
from
0adfa2f
to
14fa26d
Compare
ivy-rew
commented
Feb 26, 2024
Comment on lines
+24
to
+32
| schemas: [ | ||
| { | ||
| // If YAML file is opened matching this glob | ||
| fileMatch: ['**/ivy.yaml'], | ||
| // Then this schema will be downloaded from the internet and used. | ||
| //uri: 'https://json-schema.ivyteam.ch/ivy/11.3.9/ivy.json' | ||
| //uri: 'http://127.0.0.1:8080/system/json-schema/ivy/11.3.9/ivy.json' | ||
| uri: 'http://localhost:5173/ivy/11.3.9/ivy.json' | ||
| }, |
There was a problem hiding this comment.
uri: can't be relative ... looks like an error in monaco-yaml fetching code ... fails at runtime
ivy-rew
commented
Feb 26, 2024
| } | ||
|
|
||
| let content = `# yaml-language-server: $schema=https://json-schema.axonivy.com/ivy/11.3.1/ivy.json | ||
| let content = `# yaml-language-server: $schema=https://json-schema.axonivy.com/ivy/11.3.9/ivy.json |
There was a problem hiding this comment.
ivy.yaml editing with self-served schemas works well if no #yaml-language-server hint is set.
but we have it in all our models; for versioning reasons ... and as soon as we have an explicit schema defined, it will win over the predefined local model. :-(
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.