Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit: Get the unique id of each parameter in a lensing entity. #43

Merged
merged 15 commits into from
Jul 20, 2023

Conversation

gvernard
Copy link
Collaborator

We need a function to be called on each 'lensing entity' that returns the unique ids of its parameters. We will use these parameter ids to match them with the columns of the chain file. We could give a list of parameter names to this function (just the profile parameter name, e.g. 'q' for the axis ratio). If no arguments are given then all the parameter ids should be returned.

@aymgal aymgal closed this Jul 17, 2023
@aymgal aymgal reopened this Jul 17, 2023
@aymgal
Copy link
Owner

aymgal commented Jul 17, 2023

@gvernard I just added a new method to the LensingEntityList class that allows to retrieve the list of IDs with something like coolest.lensing_entities.get_parameter_ids(with_name=None). Let me know if this is what you needed.
You have an example usage in this notebook.

@aymgal
Copy link
Owner

aymgal commented Jul 18, 2023

@gvernard Please let me know if the new function is what you were looking for so I can merge the PR

@aymgal aymgal marked this pull request as ready for review July 20, 2023 14:20
@aymgal aymgal merged commit 1214b26 into joss Jul 20, 2023
2 checks passed
@aymgal aymgal deleted the get_parameter_ids branch July 20, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants