Allow cross-referencing in nav #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentbellnorm
approved these changes
Feb 22, 2023
agentbellnorm
requested changes
Feb 23, 2023
|
okay updated |
agentbellnorm
approved these changes
Feb 27, 2023
|
Seems like a test needs updated. |
|
@haneul Can you go ahead and update the test? I can go ahead and merge this once that's resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to add a page under different subsites (or main site) in a subsite's nav. While linking with ../ may work, but mkdocs can't properly process as it can't find the page.
It shows error like
WARNING - A relative path to 'test/../cross.md' is included in the 'nav' configuration, which is not found in the documentation filesAnd the navigation title will be None.
This PR fixes it by having normpath for nav link.