Fix tests for markdown 3, upgrade graphviz package #224
Conversation
ElementalWarrior
commented
Oct 2, 2024
ElementalWarrior
commented
- Upgrade graphviz extension
- assertEquals is a deprecated form of assertEqual
- Test module does not exist, use src
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
markdown_inline_graphviz_extension version 1.1.3 will fix markdown > 3 support. But the version only exists in the github: https://github.com/cesaremorel/markdown-inline-graphviz It hasn't been published to pypi yet. See: cesaremorel/markdown-inline-graphviz#13 For now, building from github may suffice
This code should probably be in an actual python package
|
Hi @awanlin. Any chance for a review? |
|
Thanks. This is related to #217 |
There was a problem hiding this comment.
Hi @ElementalWarrior, can we trim this down, some of the changes are bine handled already in this PR #223. There also looked to be unrelated changes that crept in like the README.md
|
@awanlin I think thats just from merging the main branch into my feature branch (because a check was failing iirc). So its github reporting things as changes that were already applied. I can rebase it if you like. But It's effectively just re-listing already applied things. |
|
Ah, I think it was pointing at the wrong base branch to merge into. |
There was a problem hiding this comment.
Hi @ElementalWarrior, I'd like to get in #223 first and then follow up with this one. Left a few comments in the mean time.
|
|
||
| # The following are more akin to direct dependencies. Each line represents one | ||
| # or more features that are provided by `techdocs-core`, and thus are always | ||
| # pinned to an exact version. Bumps should be accompanied by release notes | ||
| # explaining what was added or fixed (or at least pointing to the underlying | ||
| # release notes of the bumped package). | ||
| mkdocs-material==9.5.42 | ||
| markdown_inline_graphviz_extension==1.1.2 | ||
| markdown_inline_graphviz_extension@git+https://github.com/cesaremorel/markdown-inline-graphviz.git@v1.1.3 |
There was a problem hiding this comment.
| markdown_inline_graphviz_extension@git+https://github.com/cesaremorel/markdown-inline-graphviz.git@v1.1.3 | |
| markdown_inline_graphviz_extension===1.1.3 |
Is there a reason we don't just do the above?
| @@ -88,7 +88,7 @@ def test_theme_overrides_dirs(self): | |||
| def test_template_renders__multiline_value_as_valid_json(self): | |||
| self.techdocscore.on_config(self.mkdocs_yaml_config) | |||
| env = Environment( | |||
| loader=PackageLoader("test", self.techdocscore.tmp_dir_techdocs_theme.name), | |||
| loader=PackageLoader("src", self.techdocscore.tmp_dir_techdocs_theme.name), | |||
| @@ -98,7 +98,7 @@ def test_template_renders__multiline_value_as_valid_json(self): | |||
| } | |||
| rendered = template.render(config=config) | |||
| as_json = json.loads(rendered) | |||
| self.assertEquals(config, as_json) | |||
| self.assertEqual(config, as_json) | |||
There was a problem hiding this comment.
Let's revert this change as it will be done in #223
