fix(react-native): forward attachments added after init to iOS native crash reports - #386
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attachments added after
initialize()never reached native crash reports. Fixes iOS only.Changes
packages/react-native/src/crashReporter/CrashReporter.ts: sends the attachment set to the native crash reporter, and no-ops where the native module has no attachment support.packages/react-native/src/BacktraceClient.ts: forwards the full set on every attachment change, since the native layer replaces rather than merges.packages/react-native/tests/nativeAttachmentPropagationTests.spec.ts: covers what reaches native and what deliberately does not.ref: BT-7468