Preserve service test results across PR edits - #12089
Conversation
How so? Would I need to locate the right job, open it in the Actions interface, and click on some buttons to retry? I occasionally get the title wrong (latest example in date being #12083) and contributors regularly forget it. What I like with the existing workflow is that it's extremely low overhead, just modify the title, and it will launch the job. |
|
Yes, you have to rerun the job from its details page. There are no separate events for PR title changes and PR description changes. Feel free to close this PR if you prefer our current implementation. |
|
I like the existing setup, but I've really not got a very strong opinion. Let's let @jNullj be the tie breaker. :) |
|
Can i suggest the following:
I hope this sounds reasonable as its a bit more complex. |
Why
The Services workflow currently listens to
pull_request.edited. Description-only edits create a skippedtest-servicescheck, which replaces the previous real result in the PR UI. Giving the skipped job a different name can conflict with the requiredtest-servicescheck, while rerunning service tests on every edit can exhaust API rate limits.What
pull_request.editedAfter changing a PR title, a maintainer can rerun the existing Services workflow. Description edits leave the previous real
test-servicesresult intact.