Skip to content

Fix [DockerVersion DockerSize] pagination - #12111

Open
PyvesB wants to merge 1 commit into
badges:masterfrom
PyvesB:fix-docker-pagination
Open

Fix [DockerVersion DockerSize] pagination#12111
PyvesB wants to merge 1 commit into
badges:masterfrom
PyvesB:fix-docker-pagination

Conversation

@PyvesB

@PyvesB PyvesB commented Aug 22, 2026

Copy link
Copy Markdown
Member

Some of our Docker tests that were using images with a lot of tags started failing recently. We were getting the following error back from the API:

pagination offset too large for anonymous requests; sign in to page further

This caps the pagination to 10 pages for unauthenticated requests: in all likelihood the result we're looking for is in those 10 first pages anyway.

Additionally, our DockerSize badge was effectively fetching the first page twice, once towards the start of its handle function, and a second time in getMultiPageData. The larger refactor addresses this and saves an API call.

@PyvesB PyvesB added the service-badge New or updated service badge label Aug 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📚 Remember to ensure any changes to config.private in services/docker/docker-version.service.js are reflected in the server secrets documentation.

⚠️

📚 Remember to ensure any changes to config.private in services/docker/docker-version.spec.js are reflected in the server secrets documentation.

⚠️

📚 Remember to ensure any changes to config.private in services/docker/docker-size.service.js are reflected in the server secrets documentation.

⚠️

📚 Remember to ensure any changes to config.private in services/docker/docker-size.spec.js are reflected in the server secrets documentation.

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against defcad5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-badge New or updated service badge

Development

Successfully merging this pull request may close these issues.

1 participant