Use ェvice ャin Japanese transliteration #1436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to rectify the transliteration issue from #1420
I grepped over the codebase for all occurrences. As expected, it is only present in the Japanese localization files. I have updated the item and its associated references.
N.B. I am not Japanese nor a proficient speaker/reader/writer. That being said, I went ahead and did a cursory attempt at confirmation and am confident this is a good faith improvement. Here is a link to an unaffiliated YouTube video with the recommended spelling in the video description (Screenshot for convenience).
