Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant bancor v3 tokens to the combos and flashloan tokens #429

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

NIXBNT
Copy link
Collaborator

@NIXBNT NIXBNT commented Mar 14, 2024

Solves #427

@NIXBNT NIXBNT added the bug Something isn't working label Mar 14, 2024
return 2
else:
return 7
return 2 if tkn in b3_flashloan_tokens else 7
Copy link
Collaborator

@barakman barakman Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument of type 'NoneType' is not iterable, so you probably want to remove that None default value for this list everywhere in the code (or by the least, change it to [], though if no default value is really required, then no need to declare one).

@barakman
Copy link
Collaborator

Several tests are failing:

  1. fastlane_bot/tests/nbtest/test_900_OptimizerDetailedSlow.py::test_general_and_specific_tests - AssertionError: assert 'amtout must be negative [49.024647265676]' is None

  2. fastlane_bot/tests/test_042_TestBancorV3ModeTwoHop.py::test_test_combos - AssertionError: [test_bancor_v3_two_hop] Different data used for tests, expected ***22 combos

  3. fastlane_bot/tests/test_05***_BalancerFlashloans.py::test_test_extract_flashloan_tokens - TypeError: argument of type 'NoneType' is not iterable

  4. fastlane_bot/tests/test_06***_TestWETHConversion.py::test_wrap_unwrap_original - TypeError: argument of type 'NoneType' is not iterable

Failure 1 is a known issue in general, all the other failures are probably directly related to the changes applied in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants