-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds data validation to b3_two_hop
mode by default.
#43
Merged
mikewcasale
merged 19 commits into
main
from
42-b3_two_hop-arb-mode-resulting-in-losses-due-to-lack-of-data-validation
Jul 31, 2023
Merged
Adds data validation to b3_two_hop
mode by default.
#43
mikewcasale
merged 19 commits into
main
from
42-b3_two_hop-arb-mode-resulting-in-losses-due-to-lack-of-data-validation
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py for the bancor3 `arb_modes`
…-issue-in-confignetworkpy' into 35-bug-overwriting-of-flashloan_tokens-list-set-in-mainpy
…py' into 42-b3_two_hop-arb-mode-resulting-in-losses-due-to-lack-of-data-validation
tests are failing |
…-issue-in-confignetworkpy' into 42-b3_two_hop-arb-mode-resulting-in-losses-due-to-lack-of-data-validation
zavelevsky
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mikewcasale
deleted the
42-b3_two_hop-arb-mode-resulting-in-losses-due-to-lack-of-data-validation
branch
July 31, 2023 14:37
This was
linked to
issues
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.