-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove entries in multichain_addresses.csv of univ2 forks with no fee #607
Closed
barakman
wants to merge
17
commits into
add_sei
from
remove-illegal-entries-in-multichain-addresses-attempt-2
Closed
Remove entries in multichain_addresses.csv of univ2 forks with no fee #607
barakman
wants to merge
17
commits into
add_sei
from
remove-illegal-entries-in-multichain-addresses-attempt-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
barakman
deleted the
remove-illegal-entries-in-multichain-addresses-attempt-2
branch
May 8, 2024 13:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles issue #601, with the following doubts remaining:
multichain_addresses.csv
with no fee in them?So that issue needs to be resolved from the cause root.
Either by removing lines with invalid data, or by updating them to consist of valid data.
This PR attempts to do so by removing lines with fork=univ2 and no fee.
But there are a few doubts remaining: