-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get topics from correct event contract abi #677
Conversation
5265fd5
to
16445e4
Compare
16445e4
to
385f3d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can (and probably should) change the whole scheme to use contract.events.MyEvent.getLogs
, so we get rid of the topics
input parameter altogether, and revert back to a method which looks similar to the one previous used (taking only from_block
and to_block as input parameters). Technically, you'll need pass a
contract.events.MyEventinstance to the
get_eventsfunction, and that function will call function
getLogs` on that instance).
Perhaps, but definitely this is outside of the scope of this PR |
In a way it is, because you're already working hard in this PR to create the contracts and their list of events, so you can just replace the |
In future I want to try fetching all topics within a single request. Event.get_logs will not work with that. |
No description provided.