Balancer2 #88
Merged
Balancer2 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklbancor
force-pushed
the
balancer2
branch
7 times, most recently
from
1e9d5bb
to
dce754f
Compare
sklbancor
force-pushed
the
balancer2
branch
2 times, most recently
from
fc9fdc8
to
36da29c
Compare
sklbancor
force-pushed
the
balancer2
branch
3 times, most recently
from
b2147f3
to
a48c0b2
Compare
Update NBTest_051_CPCBalancer.ipynb
mikewcasale
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds upon the balancer pull request that introduced weighted curves in the CPC object.
We will now add an interface to the CPC object that replaces
dxdyfromp_ffor the multi-token case (aka proper balancer) calleddxvecfromdpvec_f. The functionality should be the same, the only difference is the way the parameters are passed. We then also move over the optimization core code over to the new interface.This DOES NOT CHANGE ANY FUNCTIONALITY however it does allow for future extensions
THIS PULL REQUEST SHOULD BE TESTED CAREFULLY BEFORE MERGING IT INTO THE MAIN BRANCH