🐛 fix: avoid sending HTTP request to /contest-records/real-time-rank …

…API when user is null
baoliay2008 · Sep 17, 2024 · 78feb11 · 78feb11
1 parent 2b9a007
commit 78feb11
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/client/src/components/charts/RealTimeRankChart.jsx b/client/src/components/charts/RealTimeRankChart.jsx
@@ -1,8 +1,6 @@
 import ReactEcharts from "echarts-for-react";
 
 const RealTimeRankChart = ({ user, rankList }) => {
-  if (!rankList) return null;
-
   const realTimeRank = [["Minute", "Username", "Rank"]];
   for (let j = 1; j <= rankList.length; j++) {
     realTimeRank.push([j, user.username, rankList[j - 1]]);

diff --git a/client/src/pages/Predicted/PredictedRecords.jsx b/client/src/pages/Predicted/PredictedRecords.jsx
@@ -230,13 +230,15 @@ const PredictedRecords = () => {
   // console.log(`user=${user} ${user?.username} ${user?.data_region}`);
 
   const { data: rankData } = useSWR(
-    [
-      `${baseUrl}/contest-records/real-time-rank`,
-      JSON.stringify({
-        contest_name: titleSlug,
-        user: user,
-      }),
-    ],
+    user
+      ? [
+          `${baseUrl}/contest-records/real-time-rank`,
+          JSON.stringify({
+            contest_name: titleSlug,
+            user: user,
+          }),
+        ]
+      : null,
     ([url, body]) =>
       fetch(url, {
         method: "POST",
@@ -246,6 +248,7 @@ const PredictedRecords = () => {
     { revalidateOnFocus: false }
   );
   const rankList = rankData?.real_time_rank;
+  // console.log(`rankData=${rankData} rankList=${rankList} ${rankList?.length} ${!rankList}`)
 
   if (!predictedRecords || isLoading)
     return (
@@ -304,8 +307,8 @@ const PredictedRecords = () => {
       <label htmlFor="my-modal-4" className="modal cursor-pointer">
         <label className="modal-box relative" htmlFor="">
           <div className="container mx-auto text-center">
-            {user && <RealTimeRankChart user={user} rankList={rankList} />}
-            {!user && (
+            {rankList && <RealTimeRankChart user={user} rankList={rankList} />}
+            {!rankList && (
               <div>
                 <progress className="progress w-56"></progress>
                 <p className="text-center">Loading Real Time Rank</p>