Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): make whitespace chars visible #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amekusa
Copy link

@amekusa amekusa commented Dec 19, 2022

Due to the color of whitespace characters (spaces and tabs) is same as the background color (#1F1F28), they are not visible unless being highlighted at the current line even if editor.renderWhitespace is not none.

Screen Shot 2022-12-19 at 10 48 53

So I changed editorWhitespace.foreground to be slightly lighter than editorIndentGuide.activeBackground #363646 but darker than
editorLineNumber.foreground #54546D.

This is the result:
Screen Shot 2022-12-19 at 11 07 55

@Lamarcke
Copy link

I honestly believe this is intentional. Most editors don't have editor whitespace colors, and some people don't like them.

@amekusa
Copy link
Author

amekusa commented Dec 20, 2022

Hm, If it's intentional, that's ok then. Maybe I will create a fork for my own.
But in my opinion, if you don't like whitespaces are visible, that is editor.renderWhitespace setting for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants