Add validator flags for configurable hours of blob data #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyalprout
previously approved these changes
Jun 18, 2024
cb-heimdall
dismissed
danyalprout’s stale review
Approved review 2124096861 from danyalprout is now dismissed due to new commit. Re-request for approval.
danyalprout
approved these changes
Jun 18, 2024
|
Review Error for danyalprout @ 2024-06-18 16:49:15 UTC |
|
This Pull Request was merged without enough reviews |
1 similar comment
|
This Pull Request was merged without enough reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validator flags to make the hours of blob data collected configurable.
The flags are
BLOCKS_PER_MINUTEof type int, andHOURS_OF_BLOB_DATAof type int.The hours of blob data collected is calculated as
BLOCKS_PER_MINUTE * HOURS_OF_BLOB_DATA * 60.