New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries to blob fetching #6

Merged

danyalprout merged 2 commits into master from improve-error-handling

Feb 19, 2024

Collaborator

danyalprout commented Feb 17, 2024 •

edited

Loading

Description

This PR adds retries to the following cases:

Fetching & storing the current head on startup
Live indexing of new blobs

For the live indexing case, assuming the chain state is the following state:

Beacon chain blocks:
3 -> 4 -> 5

head=5
lastArchivedBlock=3

If persisting blob 5 succeeds, but blob 4 fails, currently blob 4 wont be retried as part of live indexing and will need to be explicitly be rearchived. The additional retries reduce the likelihood of this happening due to transient errors.
If persisting blob 5 fails, this reduces the delay before it's retried (the poller is default configuration is 6s)

danyalprout added 2 commits

February 16, 2024 16:09


          Add retries on error persisting blobs to storage

20cf2d4


          Add retires on blob-archiver startup

6de7b7b

danyalprout requested a review from mdehoog

February 17, 2024 21:52

mdehoog approved these changes

View reviewed changes

danyalprout merged commit ec55442 into master

4 checks passed

danyalprout deleted the improve-error-handling branch

February 19, 2024 00:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet