fix(L1): seed imported schedule protocol version - #420
Merged
Conversation
Require imported activations to initialize their minimum packed version atomically so nodes never read a scheduled upgrade with version zero. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
Rely on the atomic initializer for schedule validation and keep deployment-state verification in the integration test. Co-authored-by: Cursor <cursoragent@cursor.com>
Validate the imported schedule and minimum version before any broadcast so a bad config cannot strand a partially deployed deterministic system. Co-authored-by: Cursor <cursoragent@cursor.com>
leopoldjoy
reviewed
Aug 25, 2026
Preserve both imported minimum-version and future-notice validation. Co-authored-by: Cursor <cursoragent@cursor.com>
Share ordering, notice, and minimum-version validation across standard and multiproof deployments so invalid configuration cannot strand partial broadcasts. Co-authored-by: Cursor <cursoragent@cursor.com>
Reserve one hour for sequential broadcasts so a future activation accepted during preflight remains valid when ProtocolVersions is initialized. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the one-off ProtocolVersions deployment library while preserving shared validation across both broadcast paths. Co-authored-by: Cursor <cursoragent@cursor.com>
leopoldjoy
approved these changes
Aug 27, 2026
CatfishbillyIII
approved these changes
Aug 27, 2026
Collaborator
|
Review Error for CatfishbillyIII @ 2026-08-27 13:21:15 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
ProtocolVersions.initializeto set the minimum packed protocol version atomically with an imported schedule and reject non-zero activation timestamps when that version is zero.protocolVersionsInitialMinimumVersionthrough the standard and multiproof deployment paths, retaining the config parser's packed-version bound check.This keeps imported activation schedules immediately consumable by nodes, which reject positive activation timestamps paired with protocol version zero.
Notes to reviewers
MIN_NOTICEplus a one-hour deployment buffer during preflight; the initializer retains its exactMIN_NOTICEtrust-boundary check.minimumProtocolVersionremains outside thescheduleIdcommitment.How has it been tested?
just testjust test --match-path test/deploy/SystemDeploy.t.soljust test --match-path test/L1/ProtocolVersions.t.soljust test --match-path test/L1/proofs/AggregateVerifier.t.soljust build-no-testsjust snapshotsforge fmt --checkjust validate-spacers-no-build