Skip to content

fix(L1): leave time for schedule propagation - #424

Merged
jackchuma merged 2 commits into
mainfrom
fix/extend-protocol-versions-freeze-window
Aug 27, 2026
Merged

fix(L1): leave time for schedule propagation#424
jackchuma merged 2 commits into
mainfrom
fix/extend-protocol-versions-freeze-window

Conversation

@jackchuma

@jackchuma jackchuma commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What changed? Why?

  • Extend ProtocolVersions.FREEZE_WINDOW from 30 minutes to one hour, independently of MIN_NOTICE, so finalized readers have time to observe schedule changes before the sequencer-drift horizon makes the prior schedule reachable.
  • Add regression coverage for the finalized-read buffer and retain the existing exact-boundary coverage.
  • Refresh the ProtocolVersions semver lock because the contract bytecode changes.

Notes to reviewers

  • The one-hour window covers the post-Fjord 30-minute maximum sequencer drift plus the default finalized reader's nominal 27m48s observation latency, leaving a 2m12s margin. This is a bounded contract-side mitigation; consumers must still reject stale schedule changes when finality or delivery delays exceed that assumption.

How has it been tested?

  • just test --match-path test/L1/ProtocolVersions.t.sol (80 passed)
  • just lint-check
  • just test (1,221 passed, 1 skipped)

Expand the ProtocolVersions freeze window to one hour so finalized readers can observe changes before sequencer drift makes the old activation reachable. Consumers must still reject stale changes when finality or delivery exceeds this bounded assumption.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cb-heimdall

cb-heimdall commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Keep the schedule freeze margin independent from the minimum notice policy so future notice changes cannot silently alter it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jackchuma
jackchuma merged commit 0831c1a into main Aug 27, 2026
6 checks passed
@jackchuma
jackchuma deleted the fix/extend-protocol-versions-freeze-window branch August 27, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants