fix(L1): leave time for schedule propagation - #424
Merged
Conversation
Expand the ProtocolVersions freeze window to one hour so finalized readers can observe changes before sequencer drift makes the old activation reachable. Consumers must still reject stale changes when finality or delivery exceeds this bounded assumption. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
Keep the schedule freeze margin independent from the minimum notice policy so future notice changes cannot silently alter it. Co-authored-by: Cursor <cursoragent@cursor.com>
leopoldjoy
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
ProtocolVersions.FREEZE_WINDOWfrom 30 minutes to one hour, independently ofMIN_NOTICE, so finalized readers have time to observe schedule changes before the sequencer-drift horizon makes the prior schedule reachable.Notes to reviewers
How has it been tested?
just test --match-path test/L1/ProtocolVersions.t.sol(80 passed)just lint-checkjust test(1,221 passed, 1 skipped)