Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbt] br_me_rais #795

Merged
merged 3 commits into from
Oct 22, 2024
Merged

[dbt] br_me_rais #795

merged 3 commits into from
Oct 22, 2024

Conversation

tricktx
Copy link
Contributor

@tricktx tricktx commented Oct 18, 2024 •
edited
Loading

  • Refatorando o código do @rdahis que estava em Stata para Python. Referência 🔗
  • Ajustando algumas impurezas que veio junto com os dados de 2023.
  • Ajustando alguns nomes no schema que estavam errados.

Testes de validações:

  1. Número de linhas por ano:

image

  1. Região norte:

    2.1 Dados originais:
    image
    2.2 BigQuery:
    image

@tricktx tricktx added table-approve Trigger action table-approve hacktoberfest-accepted Pull Requests aprovados na Hacktoberfest labels Oct 18, 2024
@tricktx tricktx requested review from rdahis and a team October 18, 2024 20:21
@tricktx tricktx self-assigned this Oct 18, 2024
@rdahis
Copy link
Member

rdahis commented Oct 20, 2024

Chegou a rodar testes comparando a versão em prod e a nova em dev @tricktx? Deve ser o melhor jeito de testar se o código está ok.

@laura-l-amaral laura-l-amaral linked an issue Oct 21, 2024 that may be closed by this pull request
[update] br_me_rais #790
Closed
@rdahis
Copy link
Member

rdahis commented Oct 21, 2024

Ok mas eu quis dizer testes em cima dos mesmos dados nas duas versões, tipo RJ em 2022 em ambas e ver se os números batem. Ou você está subindo só os dados de 2023 mesmo?

@tricktx
Copy link
Contributor Author

tricktx commented Oct 21, 2024 •
edited
Loading

Estou subindo apenas as prévias de 2023, @rdahis.

Eu fiz apenas os teste de validação para verificar se as alterações que fiz para consertar as inconsistências de 2023 não alteraram nada nos anos anteriores.

@rdahis
Copy link
Member

rdahis commented Oct 21, 2024

Entendi, ok!

@tricktx tricktx requested review from rdahis and removed request for rdahis October 22, 2024 19:06
@laura-l-amaral laura-l-amaral removed the table-approve Trigger action table-approve label Oct 22, 2024
@tricktx tricktx merged commit 6a0d5e9 into main Oct 22, 2024
3 checks passed
@tricktx tricktx deleted the update-rais-2023 branch October 22, 2024 19:53
@tricktx tricktx restored the update-rais-2023 branch October 22, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdahis rdahis rdahis left review comments

@laura-l-amaral laura-l-amaral laura-l-amaral approved these changes

Assignees

@tricktx tricktx

Labels
hacktoberfest-accepted Pull Requests aprovados na Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[update] br_me_rais
3 participants
@tricktx @rdahis @laura-l-amaral