Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Error Workaround: Generate _soundfile.py before the package editable installation #422

Merged

Conversation

aoirint
Copy link
Contributor

@aoirint aoirint commented Dec 10, 2023

Fix the CI error ModuleNotFoundError: No module named '_soundfile' on Python 3.7+.

Details: #420 (comment)


I guess I was mistaken in my perception that Windows + Python 3.11 has problems.
Instead, it seems that the Windows + pypy-3.8 test sometimes fails and sometimes succeeds.

Error message

Fatal error in the GIL or with locks: EnterNonRecursiveMutex(ms) [ffffffff,6]

It could be a pypy specific issue, but I am not familiar with it.

@aoirint aoirint marked this pull request as ready for review December 10, 2023 10:41
@aoirint
Copy link
Contributor Author

aoirint commented Dec 10, 2023

Windows, pypy-3.8, x86 test seems to be failed. Maybe retry fix it. (Hopefully the root cause could be found in time...)

Fatal error in the GIL or with locks: EnterNonRecursiveMutex(ms) [ffffffff,6]

@bastibe bastibe merged commit 4d401f9 into bastibe:master Dec 10, 2023
30 of 31 checks passed
@bastibe
Copy link
Owner

bastibe commented Dec 10, 2023

Beautiful! Thank you very much!

@aoirint aoirint deleted the patch-ci-workaround-soundfile-cffi-generation branch December 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants