Skip to content

Commit

Permalink
feat: detect stardoc output change (#75)
Browse files Browse the repository at this point in the history
Allows Bazel 8 upgrades in rulesets where docgen diff tests otherwise
fail, for example
https://github.com/aspect-build/rules_lint/pull/401/files
  • Loading branch information
alexeagle authored Oct 9, 2024
1 parent 7981a69 commit 24b019d
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion features.bzl
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Defines all the features this module supports detecting."""

load("@bazel_features_globals//:globals.bzl", "globals")
load("//private:util.bzl", "ge", "ge_same_major", "lt")
load("//private:util.bzl", "ge", "ge_same_major", "gt", "lt")

_cc = struct(
# Whether @bazel_tools//tools/cpp:optional_current_cc_toolchain and the `mandatory` parameter
Expand Down Expand Up @@ -33,6 +33,12 @@ _cc = struct(
protobuf_on_allowlist = ge("8.0.0"),
)

_docs = struct(
# The stardoc output changed in https://github.com/bazelbuild/bazel/commit/bd1c3af2ea14e81268e940d2b8ba5ad00c3f08d7
# This may be required for "diff tests" that assert on the generated API docs.
kwargs_name_with_double_star = ge("8.0.0-pre.20240603.2"),
)

_external_deps = struct(
# Whether --enable_bzlmod is set, and thus, whether str(Label(...)) produces canonical label
# literals (i.e., "@@repo//pkg:file").
Expand Down Expand Up @@ -98,6 +104,7 @@ _toolchains = struct(

bazel_features = struct(
cc = _cc,
docs = _docs,
external_deps = _external_deps,
flags = _flags,
globals = globals,
Expand Down

0 comments on commit 24b019d

Please sign in to comment.