fix: various fixes for the deps library - #4106
Merged
rickeylev merged 3 commits intoAug 24, 2026
Merged
Conversation
Correctly wire args around and disable precompiling for the deps nodes. Work towards bazel-contrib#2948
rickeylev
approved these changes
Aug 23, 2026
rickeylev
reviewed
Aug 23, 2026
rickeylev
left a comment
rickeylev
left a comment
Collaborator
There was a problem hiding this comment.
this is titled fix, but there's no news entry. is it fixing a released user visible behavior? If so, please add news
…pectation Fix CI analysis and test failures caused by an undefined variable in whl_library_targets and missing precompile attribute expectation in analysis tests. Change deps_template to dep_template in whl_library_targets and add "precompile": "disabled" to the expected py_library dictionary in whl_library_deps_targets tests.
Address code review feedback on PR bazel-contrib#4106 by wrapping docstrings and improving comment clarity. Wrap whl_library_deps_targets docstrings to 80 columns, clarify the rationale for setting precompile = "disabled" on the wrapper target, and remove a redundant comment in whl_library_targets.
Collaborator
Author
The APIs have never been said to be public and available to be used. Though, I can add a news item if needed. |
rickeylev
approved these changes
Aug 24, 2026
Collaborator
|
I'm fine with omitting a news entry. I'm fine with omitting news for non-public behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly wire args around and disable precompiling
for the deps nodes.
Work towards #2948