-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable analysis caching codepaths only for commands that execute acti…
…ons. For example, this includes `test` and `build`, but does not include `cquery`. This prevents the use case where the someone adds `build --experimental_remote_analysis_cache_mode=download` by default into their bazelrc, and runs a cquery command (which, WAI, picks up the flag, because `CqueryCommand` inherits options from `TestCommand`, which inherits from `BuildCommand`), and fails to this cryptic error: ``` $ bazel cquery 'somepath(//foo, //bar)' ERROR: Failed to find PROJECT.scl file for: [//foo:foo, //bar:bar] INFO: Elapsed time: 0.078s ERROR: Build did NOT complete successfully ``` It also doesn't make sense to support analysis caching with cquery anyway, because correct results require a complete, unpruned analysis graph. Same goes for `aquery`. PiperOrigin-RevId: 689397164 Change-Id: Ib63ab41450b84e782d69e148196b2bfa6413e65f
- Loading branch information
1 parent
8d0e66b
commit 68f94a1
Showing
4 changed files
with
37 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters