-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use a visitor pattern to consume fileset symlinks.
Instead of constructing a `FilesetManifest`, callers use a `Visitor` that is invoked for every symlink in the fileset. This allows for an optimization: when the fileset has no relative symlinks (or we are ignoring relative symlinks), we can do a single-pass visitation without building up maps. Additionally, callers are responsible for concatenating the fileset-relative and execroot-relative paths to their roots. This reduces garbage from concatenating paths, since some callers don't need them. PiperOrigin-RevId: 683222046 Change-Id: I80f04306e7a617d3c3e630c56d96b2c968eb1d42
- Loading branch information
1 parent
ae02744
commit dfe0aee
Showing
9 changed files
with
263 additions
and
350 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
327 changes: 152 additions & 175 deletions
327
src/main/java/com/google/devtools/build/lib/actions/FilesetOutputTree.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.