-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java "11" is not required (especially for Windows) #23882
Comments
Would you be interested in sending a PR? |
Not now or in this week. |
Sorry, my comment at google/mozc#932 (comment)_ might have been misleading. I was trying to explain that running Bazel itself would not require any explicit installation of Java Runtime Environment (JRE) these days, while the installation document looks to be saying that an explicit explicit installation of Java Development Kit (JDK) will be needed to build code written in Java by using Bazel, which I believe is still valid (except for which JDK version should be installed most likely depends on the target project you want to build). bazel/site/en/install/windows.md Lines 108 to 112 in 83830c2
In google/mozc#932 the reporter did not need to install JDK because the project that the reporter was trying to build a project (for Windows) did not have any Java build target. This does not mean that JDK is completely unnecessary to build other projects that need to build Java source code. So removing JDK entry may also cause another confusion. Just fyi. |
Thank you for the additional explanation. We might verify whether the installation of JDK is really unnecessary using Sandbox or VM. |
I uninstalled MSYS2, Bazel, and Java 21 (Eclipse Temurin), and reinstalled only MSYS2 and Bazel via Scoop.
Bazel is successfully compiling C++ source code files without a local JDK. |
Right. You don't need JDK as long as Mozc is the only project you want to build with Bazel. https://bazel.build/install/windows#install-compilers is actually saying that what additional tools are needed depend on what you want to build.
In other words, you can use Bazel without installing Visual C++ Build Tools and Windows 10 SDK. Bazel itself can run without them, but the build may or may not fail depending on the target project requirements. And as for Mozc, the build will actually fail on Windows. If you happened to have to build Java-based project such as Bazel itself, you would still need to install JDK, I guess. |
I'll fix
I see. There's a description "You will need this to build Java code on Windows.". |
Page link:
https://bazel.build/install/windows#install-compilers
Problem description (include actual vs expected text, if applicable):
bazel/site/en/install/windows.md
Line 108 in 83830c2
This line is incorrect and confused me a lot. It should be removed.
google/mozc#932 (comment)
Bazel for Windows these days automatically installs Zulu 21.
Where do you see this issue? (include link to specific section of the page, if applicable)
No response
Any other information you'd like to share?
Python "3.6" is a stale information too.
The text was updated successfully, but these errors were encountered: