Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows build instruction #1079

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Oct 14, 2024

Description

A clear and concise description of this pull request.

There are some confusing pitfalls in Windows build insturction with Bazel. This PR improve it and make it easier for Windows users to build Mozc with Bazel.

Issue IDs

Issue and/or discussion IDs related to this pull request.

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: Windows 11
  • Steps:
    1. Build Mozc by the steps written in docs/build_mozc_in_windows.md

Additional context

Add any other context about the pull request here.

Copy link
Collaborator

@hiroyuki-komatsu hiroyuki-komatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi tats-u,
Thank you for your PR!

docs/build_mozc_in_windows.md Outdated Show resolved Hide resolved
docs/build_mozc_in_windows.md Outdated Show resolved Hide resolved
docs/build_mozc_in_windows.md Outdated Show resolved Hide resolved
docs/build_mozc_in_windows.md Outdated Show resolved Hide resolved
@hiroyuki-komatsu hiroyuki-komatsu merged commit be811bf into google:master Oct 15, 2024
1 check passed
@hiroyuki-komatsu
Copy link
Collaborator

We have merged your PR.
Thank you for the contribution!

@tats-u tats-u deleted the fix-win-build-instruction branch October 15, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants