Fixes _module_repo_name when building with Bazel@HEAD or Bazel 7.1 #21486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `get_canonical_repo_name` no longer returns the repo name with version due to containing bazelbuild@a54a393, the `_module_repo_name` should not either. Fixes: bazelbuild#21292 Closes bazelbuild#21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f
github-actions
bot
added
the
awaiting-review
|
Cherrypick is needed to fix 8.0.0-pre.20240213.1: https://buildkite.com/bazel-trusted/bazel-release/builds/1359 |
meisterT
approved these changes
Feb 23, 2024
fweikert
merged commit f4205cf
into
bazelbuild:release-8.0.0-pre.20240213.1rc1
33 checks passed
github-actions
bot
removed
the
awaiting-review
fweikert
added a commit
to fweikert/bazel
that referenced
this pull request
Mar 5, 2024
…azelbuild#21486) If `get_canonical_repo_name` no longer returns the repo name with version due to containing bazelbuild@a54a393, the `_module_repo_name` should not either. Fixes: bazelbuild#21292 Closes bazelbuild#21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f Co-authored-by: Yun Peng <pcloudy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
get_canonical_repo_nameno longer returns the repo name with version due to containing a54a393, the_module_repo_nameshould not either.Fixes: #21292
Closes #21324.
PiperOrigin-RevId: 606646238
Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f