Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s390x support for Bazel #23222

Closed
wants to merge 1 commit into from
Closed

Add s390x support for Bazel #23222

wants to merge 1 commit into from

Conversation

sangitanalkar
Copy link
Contributor

Hello,

Please help in adding following changes to support s390x for Bazel.

  1. jdk21 support.
  2. jq support.
  3. Python version upgrade as test run fails on s390x with 3.8

Thanks and Regards,
Sangita

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 6, 2024
@iancha1992 iancha1992 added team-Rules-Java Issues for Java rules team-Rules-Python Native rules for Python labels Aug 6, 2024
@sangitanalkar
Copy link
Contributor Author

Hello, Could anyone please take a look? Thank you..

@sangitanalkar
Copy link
Contributor Author

@meteorcloudy Could you please have a look? Thank you.

meteorcloudy
meteorcloudy approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website and removed team-Rules-Java Issues for Java rules team-Rules-Python Native rules for Python labels Sep 17, 2024
@meteorcloudy
Copy link
Member

Sorry for the delayed review on this one.

@meteorcloudy
Copy link
Member

@sangitanalkar Can you please rebase to Bazel HEAD?

@sangitanalkar
Copy link
Contributor Author

@sangitanalkar Can you please rebase to Bazel HEAD?

Done. Thanks.

@sangitanalkar
Copy link
Contributor Author

sangitanalkar commented Sep 19, 2024 •
edited
Loading

@sangitanalkar Can you please rebase to Bazel HEAD?

@meteorcloudy I have rebased to Bazel HEAD, could you please help in merging the changes?

@meteorcloudy
Copy link
Member

Yes, this change has been imported, will be merged very soon!

@github-actions github-actions bot removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally awaiting-review PR is awaiting review from an assigned reviewer labels Sep 19, 2024
fmeum pushed a commit to fmeum/bazel that referenced this pull request Sep 20, 2024
@sangitanalkar @fmeum
Add s390x support for Bazel
43fe014 
Hello,

Please help in adding following changes to support s390x for Bazel.

1. jdk21 support.
2. jq support.
3. Python version upgrade as test run fails on s390x with 3.8

Thanks and Regards,
Sangita

Closes bazelbuild#23222.

PiperOrigin-RevId: 676478384
Change-Id: Iaa904d85a661391253e6e5c210ef4fafc1c047af
iancha1992 pushed a commit that referenced this pull request Sep 20, 2024
@sangitanalkar @iancha1992
Add s390x support for Bazel
74174d4 
Hello,

Please help in adding following changes to support s390x for Bazel.

1. jdk21 support.
2. jq support.
3. Python version upgrade as test run fails on s390x with 3.8

Thanks and Regards,
Sangita

Closes #23222.

PiperOrigin-RevId: 676478384
Change-Id: Iaa904d85a661391253e6e5c210ef4fafc1c047af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sangitanalkar @meteorcloudy @iancha1992