Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] Deduplicate calls to config.is_sibling_repository_layout() #23528

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

bazel-io
Copy link
Member

@bazel-io bazel-io commented Sep 5, 2024

This showed up in Starlark CPU profiles and is not negligible as it repeatedly checks allowlists.

Closes #23256.

PiperOrigin-RevId: 671444687
Change-Id: I6e64b0c94332a54fcc5d531ff0e3aab176b7bd0a

Commit b85db78

This showed up in Starlark CPU profiles and is not negligible as it repeatedly checks allowlists.

Closes bazelbuild#23256.

PiperOrigin-RevId: 671444687
Change-Id: I6e64b0c94332a54fcc5d531ff0e3aab176b7bd0a
@bazel-io bazel-io added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2024
@bazel-io bazel-io requested a review from a team as a code owner September 5, 2024 18:28
@fmeum
Copy link
Collaborator

fmeum commented Sep 19, 2024

@pzembrod Friendly ping

@iancha1992 iancha1992 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into bazelbuild:release-7.4.0 with commit 5906cf1 Sep 26, 2024
51 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants