-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do no crash if a requested resource is not available #23541
Closed
AlessandroPatti
wants to merge
1
commit into
bazelbuild:master
from
AlessandroPatti:apatti/19572/error
Closed
Do no crash if a requested resource is not available #23541
AlessandroPatti
wants to merge
1
commit into
bazelbuild:master
from
AlessandroPatti:apatti/19572/error
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set. at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499) at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540) ``` After: ``` ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory ``` Fixes bazelbuild#19572
github-actions
bot
added
team-Performance
Issues for Performance teams
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Sep 6, 2024
DavidANeil
approved these changes
Oct 3, 2024
meisterT
approved these changes
Oct 4, 2024
meisterT
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Oct 4, 2024
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Oct 4, 2024
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Oct 9, 2024
Before: ``` Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set. at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499) at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540) ``` After: ``` ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory ``` Fixes bazelbuild#19572 Closes bazelbuild#23541. PiperOrigin-RevId: 682282327 Change-Id: Ifdff5f85de9e45ac119c2a2cfd161c054a722546 (cherry picked from commit e5ab94b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Before: ``` Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set. at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499) at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540) ``` After: ``` ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory ``` Fixes #19572 Closes #23541. PiperOrigin-RevId: 682282327 Change-Id: Ifdff5f85de9e45ac119c2a2cfd161c054a722546 (cherry picked from commit e5ab94b) Closes #23868 Co-authored-by: Alessandro Patti <ale812@yahoo.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fixes #19572