Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do no crash if a requested resource is not available #23541

Closed
wants to merge 1 commit into from
Closed

Do no crash if a requested resource is not available #23541

wants to merge 1 commit into from

Conversation

AlessandroPatti
Copy link
Contributor

Before:

Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set.
    at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499)
    at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540)

After:

ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory

Fixes #19572

@AlessandroPatti
Do no crash if a requested resource is not available
9cbe77b 
Before:
```
Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set.
    at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499)
    at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540)
```
After:
```
ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory
```

Fixes bazelbuild#19572
@github-actions github-actions bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Sep 6, 2024
@AlessandroPatti AlessandroPatti mentioned this pull request Oct 3, 2024
Closed
@fmeum
Copy link
Collaborator

fmeum commented Oct 3, 2024

@meisterT

@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 4, 2024
@fmeum
Copy link
Collaborator

fmeum commented Oct 4, 2024

@bazel-io fork 7.4.0

@bazel-io bazel-io mentioned this pull request Oct 4, 2024
Closed
@copybara-service copybara-service bot closed this in e5ab94b Oct 4, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 4, 2024
fmeum pushed a commit to fmeum/bazel that referenced this pull request Oct 9, 2024
@AlessandroPatti @fmeum
Do no crash if a requested resource is not available
a0a82bf 
Before:
```
Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set.
    at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499)
    at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540)
```
After:
```
ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory
```

Fixes bazelbuild#19572

Closes bazelbuild#23541.

PiperOrigin-RevId: 682282327
Change-Id: Ifdff5f85de9e45ac119c2a2cfd161c054a722546
(cherry picked from commit e5ab94b)
@fmeum fmeum mentioned this pull request Oct 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@fmeum @AlessandroPatti
[7.4.0] Do no crash if a requested resource is not available (#23911)
c2c4a39 
Before:
```
Caused by: java.util.NoSuchElementException: Resource foo is not tracked in this resource set.
    at com.google.devtools.build.lib.actions.ResourceManager.assertExtraResourcesTracked(ResourceManager.java:499)
    at com.google.devtools.build.lib.actions.ResourceManager.areResourcesAvailable(ResourceManager.java:540)
```
After:
```
ERROR: src/test/java/com/google/devtools/build/lib/actions/BUILD:102:10: Testing //src/test/java/com/google/devtools/build/lib/actions:ActionsTests failed: Resource foo is not being tracked by the resource manager. Available resources are: cpu, memory
```

Fixes #19572

Closes #23541.

PiperOrigin-RevId: 682282327
Change-Id: Ifdff5f85de9e45ac119c2a2cfd161c054a722546 
(cherry picked from commit e5ab94b)

Closes #23868

Co-authored-by: Alessandro Patti <ale812@yahoo.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

@DavidANeil DavidANeil DavidANeil approved these changes

Assignees
No one assigned
Labels
team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a resources:ram:1234 tag to a test doesn't work and causes a crash
4 participants
@AlessandroPatti @fmeum @meisterT @DavidANeil