Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bazel's embedded JDK to 23 #23651

Closed
wants to merge 1 commit into from
Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 18, 2024

In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows --watchfs to handle a configurable number of changes to a watched path rather than maxing out at 500.

s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.

@fmeum fmeum marked this pull request as draft September 18, 2024 10:20
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 18, 2024
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 18, 2024

cc @coeuvre as we talked about Loom performance testing with the most recent JDK used at Google

@zhengwei143 zhengwei143 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 18, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 18, 2024

@bazel-io fork 7.4.0

@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label Sep 18, 2024
@meteorcloudy
Copy link
Member

@fmeum Do you now how stable a new non-LTS JDK version usually is? I'm fine merging this at HEAD but do you see any risk of backporting it to 7.4.0?

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 19, 2024
@fmeum fmeum deleted the jdk-23 branch September 19, 2024 09:57
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 19, 2024

@meteorcloudy Non-LTS JDKs are generally as stable as LTS releases, they are just not maintained with patches for longer than 6 months. But I don't think we have cherry-picked JDK updates before anyway ;-)

That said, I have seen some commits to keep it up-to-date with the more recent JDK used internally for Blaze. We should also cherry-pick those if necessary. @cushon @coeuvre Do you happen to recall which changes have been necessary to keep running with the latest JDK?

@meteorcloudy
Copy link
Member

There are already some failures in https://buildkite.com/bazel/bazel-bazel/builds/29313#019209b3-4de9-4d46-87ae-8f7a13a68db4 (Not sure why they are not caught in presubmit)

Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/8918/execroot/_main/_tmp/a3e8969f357bed22ac8b1eeab84a428c/root/0e49712d29d8b302bc0b6e65669ad849/server/jvm.out')

@meteorcloudy
Copy link
Member

meteorcloudy commented Sep 19, 2024

@fweikert looks like the presubmit skipped most of the tests: https://buildkite.com/bazel/google-bazel-presubmit/builds/83889, I think this is a known issue of bazel-diff? Can we add the repositories.bzl to some allow list to make sure all tests are triggered?

copybara-service bot pushed a commit that referenced this pull request Sep 19, 2024
*** Reason for rollback ***

Broke Bazel postsubmit: #23651 (comment)

*** Original change description ***

Update Bazel's embedded JDK to 23

In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.

Closes #23651.

PiperOrigin-RevId: 676408630
Change-Id: Iffbb319c20127a3df72e4e29db248550ea328b51
fweikert added a commit to bazelbuild/continuous-integration that referenced this pull request Sep 19, 2024
@fweikert
Copy link
Member

meteorcloudy pushed a commit to bazelbuild/continuous-integration that referenced this pull request Sep 19, 2024
iancha1992 pushed a commit that referenced this pull request Sep 20, 2024
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.

Closes #23651.

PiperOrigin-RevId: 676335578
Change-Id: I991c65c6d0d44469401666d0b123a2de31804f02
iancha1992 pushed a commit that referenced this pull request Sep 20, 2024
*** Reason for rollback ***

Broke Bazel postsubmit: #23651 (comment)

*** Original change description ***

Update Bazel's embedded JDK to 23

In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.

Closes #23651.

PiperOrigin-RevId: 676408630
Change-Id: Iffbb319c20127a3df72e4e29db248550ea328b51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants