[7.4.0] Support layering_check with C++ path mapping
#23671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can opt into path mapping for C++ module map actions via `--modify_execution_info=CppModuleMap=+supports-path-mapping`. This is achieved by mapping paths in the module map files as well as converting the sequence variable for module map paths to a new structured `ArtifactSequenceVariable`. Also makes it so that `ExecutionServer` gracefully handles failing commands instead of crashing. Closes bazelbuild#22957. PiperOrigin-RevId: 675073116 Change-Id: I13835c7fb01354a89ec5fd141cf892c6b733efe4
fmeum
changed the title
layering_check with C++ path mappinglayering_check with C++ path mapping
github-actions
bot
added
awaiting-review
comius
approved these changes
Sep 23, 2024
comius
added
awaiting-PR-merge
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Sep 23, 2024
fd83239
51 checks passed
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can opt into path mapping for C++ module map actions via
--modify_execution_info=CppModuleMap=+supports-path-mapping. This is achieved by mapping paths in the module map files as well as converting the sequence variable for module map paths to a new structuredArtifactSequenceVariable.Also makes it so that
ExecutionServergracefully handles failing commands instead of crashing.Closes #22957.
PiperOrigin-RevId: 675073116
Change-Id: I13835c7fb01354a89ec5fd141cf892c6b733efe4
Fixes #23178